Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226510
Michal Nowak mnowak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@redhat.com Flag| |needinfo?(harald@redhat.com | |)
--- Comment #14 from Michal Nowak mnowak@redhat.com 2009-04-09 10:01:46 EDT --- * udev.src: W: strange-permission start_udev 0755
Not that common to ship SourceX files with exec perms, but installed via 0755, so, OK.
* udev.src: W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 104)
Easy stuff.
* udev.x86_64: E: binary-or-shlib-defines-rpath /lib/udev/vol_id ['/lib64']
Rpath is blocker in review, even such common path, fix it, please. https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath
* udev.x86_64: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp.conf
Sure, this is in /etc but not expected to be changed by user but in spec file is expected to note, why you don't have %config(noreplace), see https://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files That's what Jon asked for.
* udev.x86_64: W: dangerous-command-in-%trigger rm * udev.x86_64: W: dangerous-command-in-%trigger rm
OK.
* udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post * udev.x86_64: W: service-default-enabled /etc/rc.d/init.d/udev-post
Clear.
* udev.x86_64: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/udev-post
Easy to fix, but somewhat useless.
* udev.x86_64: W: incoherent-init-script-name udev-post
Will you fix it to "udev", or what was the resolution?
* libudev-devel.x86_64: W: no-dependency-on libudev/libudev-libs/liblibudev
Bad guess, rpmlint. OK.