https://bugzilla.redhat.com/show_bug.cgi?id=1060929
Dan Callaghan dcallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
--- Comment #2 from Dan Callaghan dcallagh@redhat.com --- Thanks for taking this review!
(In reply to Michael Scherer from comment #1)
Issues:
- Package should contains Requires: ruby(release).
see https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby
That is for pure Ruby packages, so that they can be used with any Ruby interpreter (either MRI or JRuby). However this is a compiled extension for MRI, it doesn't work in JRuby, so it should just require ruby.
- test suite is not run, despites being present
That's a good point. The test suite is failing for me with some bizarre errors so I will need to investigate some more.