https://bugzilla.redhat.com/show_bug.cgi?id=1731111
--- Comment #2 from Martin Sehnoutka msehnout@redhat.com --- (In reply to Patrik Kopkan from comment #1)
You need to add license file somewhere
change: %license -> %license LICENSE %doc -> %doc README.md
ok
Also it would be good to have downloadable source and version matching release in github repo. So if you do release you get easily both.
Otherwise version should be done this way https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ #_snapshots and the would look like this https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ #_commit_revision
%global commit b218430bfa0f78b8ae07d9303028df4d24ad8b6f %global shortcommit %(c=%{commit}; echo ${c:0:7})
Source0: https://github.com/larskarlitski/osbuild/archive/%%7Bcommit%7D/%%7Bname%7D- %{shortcommit}.tar.gz expanded: Source: https://github.com/larskarlitski/osbuild/archive/ b218430bfa0f78b8ae07d9303028df4d24ad8b6f/osbuild-b218430.tar.gz
yes, this is something to decide, but we'd like to use packit for this package, so this might be related
what about this line?
%{?python_provide:%python_provide python3-%{pypi_name}}
is it ok? because the package's name isn't python3-osbuild