https://bugzilla.redhat.com/show_bug.cgi?id=1245929
--- Comment #2 from Mohamed El Morabity pikachu.2014@gmail.com --- (In reply to Michael Cronenworth from comment #1)
- License file is missing. You can add one and open a request for upstream
to include it.
Upstream provides a copyright file in the debian/ subfolder, probably to meet Debian's packaging guidelines. I should use it since it's already available.
- licensecheck reveals BSD and LGPL licensed files, and also many files
using an incorrect FSF address. You can ask upstream to update their license clauses and add the missing licenses to the spec.
The BSD headers are only used when platform is built on Windows.
By the way, two issues detected by a Debian packager may impact this review: 1) licensing issue: https://github.com/Pulse-Eight/platform/issues/12 2) bundled library I missed (fstrcmp): https://github.com/Pulse-Eight/platform/issues/13 Unbundling this library may solve the licensing conflict above (since latest versions seem to be full-GPLv2+).