https://bugzilla.redhat.com/show_bug.cgi?id=1111691
--- Comment #4 from David Nichols david@qore.org --- (In reply to Jason Taylor from comment #1)
Hi David,
I would take a look at https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL for your Source URL information.
ok done
http://fedoraproject.org/wiki/Packaging:DistTag also provides some information on conditionals to clean up the rh_dist you define in the spec.
ok done
I am not sure if the suse/sles related conditional logic is allowable since it isn't pertinent, someone else may be able to offer insight.
ok removed
The duplicate License: declaration also seems unnecessary
%defattr is unnecessary
%clean is unnecessary unless supporting el5
ok - all done
thanks very much for the excellent review and help!
David