Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: junit4 - java regression testing framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247513
------- Additional Comments From bkonrath@redhat.com 2007-08-01 17:14 EST ------- New files:
http://bagu.org/eclipse/junit4.spec http://bagu.org/eclipse/junit4-4.3.1-1jpp.2.fc8.src.rpm
(In reply to comment #2)
Created an attachment (id=160393)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160393&action=vie...) [edit]
Detailed review
Overview of things that need attention: X * skim the summary and description for typos, etc. # The summary is outdated - references EPL which may confuse people. See patch # for fix from http://www.junit.org/index.htm
Fixed
X * correct buildroot
- should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
# Needs to be fixed
Fixed
X * license text included in package and marked with %doc # cpl-v10.html should be included in %doc
This license file is not installed so it's not needed.
X * rpmlint on <this package>.srpm gives no output # tab and space mixing issues: see patch
Fixed
X * run rpmlint on the binary RPMs
Fix most issues. Running rpmlint on the binary rpm now gives these messages:
%% rpmlint RPMS/x86_64/junit4-* E: junit4 no-binary
This is ok because that package currently doesn't have binary files since aot-compile-rpm is temporarily disabled due to gcj bugs.
E: junit4-debuginfo empty-debuginfo-package
Again, this package is empty because aot-compile-rpm is temporarily disabled due to gcj bugs.
W: junit4-demo no-documentation
There is no documentation for the demo packages.