Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=507223
--- Comment #6 from Peter Robinson pbrobinson@gmail.com 2009-07-03 09:03:31 EDT ---
That said, I am not sure, this package should enter Fedora.
Why?
Fedora's mission is to be a "leading edge distro", not a "bleeding edge" distro, consisting of more or less non-functional, immature packages.
IMO, this package is not unlikely of the latter kind.
That is your opinion, not mine or others I've spoken to, its not a topic for a bug report.
Besides this, I am not excited about how you package your moblin packages. In particular, I consider you to be acting pretty careless wrt. the autotools, NVRs and further details.
What's exactly wrong with them,
You should not run the autotools at build-time, but run them in advance and add the result through patches - That's how the autotools are supposed to be used.
By not doing so, you are exposing yourselves to the risks of non-determinisic builts and your users to risks of exposing them to mis-built packages.
But its a much used method within packages. Same as above its not a discussion to be had on a bug report but a discussion to be bought up as a proposed on fedora-devel if you feel strongly about it.
I believe the adhere to to the Package Guidelines but its always possible that I've missed stuff.
The FPG doesn't contain a rule mandating it, because certain key-people in Fedora refuse to implement such a rule and prefer to expose people to risks because "it's so convenient".
My opinion differs substantially. I conside running the autotools during builts as elementary beginners mistake and refuse to review any package doing so.
I'm not making you review my package and as you mentioned its your opinion. I don't necessarily disagree but until upstream do proper 'make dist' packages its going to remain the way it is. Its a perfectly valid package as the current packaging requirements. Packaging guidelines discussions are for the mailing list.