https://bugzilla.redhat.com/show_bug.cgi?id=1319289
--- Comment #5 from Mukundan Ragavan nonamedotc@gmail.com ---
(In reply to Antonio Trande from comment #4)
(In reply to Mukundan Ragavan from comment #3)
Package Review
- If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
---> License file is installed in the main package.
/usr/share/gems/gems/review-1.7.2/COPYING
But, license file should be installed like this -
%license %{gem_instdir}/LICENSE
Okay.
There is one mistake in the spec file. You are installing the license file and immediately excluding it.
%license %{gem_instdir}/COPYING
<snip>
%exclude %{gem_instdir}/COPYING
Why?
I got rid of the exclude line and built a package. See the difference in files here -
$ diff -Nu w_excld wo_excld --- w_excld 2016-04-20 18:58:21.183113956 -0400 +++ wo_excld 2016-04-20 18:57:55.818377962 -0400 @@ -11,6 +11,7 @@ /usr/bin/review-validate /usr/bin/review-vol /usr/share/gems/gems/review-1.7.2 +/usr/share/gems/gems/review-1.7.2/COPYING /usr/share/gems/gems/review-1.7.2/ChangeLog /usr/share/gems/gems/review-1.7.2/Dockerfile /usr/share/gems/gems/review-1.7.2/Gemfile
wo_excld - package build without the exclude lien w_excld - package build with the spec linked here.
-doc package will have no difference. Please fix this.
/usr/share/gems/gems/review-1.7.2/lib/uuid.rb 644 /usr/bin/env
---> Please review.
Fixed.
---> This does not seem to be fixed.
$ rpmls rubygem-review-1.7.2-2.fc25.noarch.rpm
<snip>
-rw-r--r-- /usr/share/gems/gems/review-1.7.2/lib/uuid.rb
<snip>
Other than these two, I do not have any other issues. Please take a look. I am ready to approve once these are taken care of.