Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: junit4 - java regression testing framework
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247513
------- Additional Comments From vivekl@redhat.com 2007-08-01 01:08 EST ------- Created an attachment (id=160393) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160393&action=vie...) Detailed review
Overview of things that need attention: X * skim the summary and description for typos, etc. # The summary is outdated - references EPL which may confuse people. See patch # for fix from http://www.junit.org/index.htm X * correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) # Needs to be fixed
X * license text included in package and marked with %doc # cpl-v10.html should be included in %doc
X * rpmlint on <this package>.srpm gives no output # tab and space mixing issues: see patch
X * run rpmlint on the binary RPMs XNote: group warnings can be ignored. # Results from binary rpm rpmlint-ing #$ rpmlint -v /var/lib/mock/fedora-7-x86_64/root/builddir/build/RPMS/junit4-* #I: junit4 checking #W: junit4 wrong-file-end-of-line-encoding /usr/share/doc/junit4-4.3.1/README.html #I: junit4-debuginfo checking #I: junit4-demo checking #W: junit4-demo no-documentation #I: junit4-javadoc checking #I: junit4-manual checking #W: junit4-manual wrong-file-end-of-line-encoding /usr/share/doc/junit4-manual-4.3.1/faq/faq.htm #W: junit4-manual wrong-file-end-of-line-encoding /usr/share/doc/junit4-manual-4.3.1/testinfected/testing.htm #W: junit4-manual wrong-file-end-of-line-encoding /usr/share/doc/junit4-manual-4.3.1/index.htm #W: junit4-manual wrong-file-end-of-line-encoding /usr/share/doc/junit4-manual-4.3.1/cookbook/cookbook.htm #W: junit4-manual wrong-file-end-of-line-encoding /usr/share/doc/junit4-manual-4.3.1/cookstour/cookstour.htm
SHOULD: X * package should include license text in the package and mark it with %doc # See above, might need fixing