Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: man-pages-es
https://bugzilla.redhat.com/show_bug.cgi?id=226124
------- Additional Comments From musuruan@gmail.com 2007-12-06 09:54 EST ------- Are you sure this line is correct?
iconv -f UTF-8 -t UTF-8 %{_builddir}/%{name}-%{version}/$i -o %{_builddir}/%{name}-%{version}/$i.utf8
It converts from UTF-8 to UTF-8...
Unresolved issues:
16.
New issues:
18. I think I missed this one in the main review. There is no need to specify the builddir path. You can (and really should) write the lines like the following:
mv %{_builddir}/%{name}-%{version}/%{extra_pkg_name}/README %{_builddir}/%{name}-%{version}/README.extra
in this way:
mv %{extra_pkg_name}/README %{extra_pkg_name}/README.extra
I suggest you to leave extra package docs in %{extra_pkg_name} and then use
%doc {extra_pkg_name}/README.extra
19. In the install section there is an old conversion to UTF-8 that is commented. I think you should delete it.
20. There is no really %build section. Move its content to %prep. Rpmlint will give a warning with an empty %build section, but in this case it is OK.