https://bugzilla.redhat.com/show_bug.cgi?id=1315020
--- Comment #13 from Mukundan Ragavan nonamedotc@gmail.com --- (In reply to Jonathan Underwood from comment #10)
Ok, this is looking great. I'm going to set it as passed review, but I'd urge you to consider adding more tests during %check to check you can import other modules than just the fileio modules. You can do simple checks just to see if the module successfully imports. Eg. (taken from python-lz4.spec):
PYTHONPATH=$RPM_BUILD_ROOT%{python2_sitearch} %{__python2} -c "import lz4"
These sorts of simple tests do actually catch breakage sometimes, so do have use.
Thanks for your contribution to Fedora, and thanks for being so quick to respond to the review.
APPROVED
I am going to email upstream about some tests that I see in the git repo. If the tests will not be added to next release, I will add additional tests like you have mentioned.
Thanks a lot for the quick review. Much appreciated.