On 05/13/2011 08:23 AM, Eric Blake wrote:
> + rollbackf=$snapshotdir/`basename "$f"`
Again, prefer $().
It's unlikely that $f will ever start with '-' (for that to happen,
@sysconfdir@ has to be a relative path), but if it were possible, you
would want 'basename -- "$f"'.
Or, better yet, save a fork and use the POSIX-guaranteed:
rollbackf=$snapshotdir/${f##*/}
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org