On Sun, 2007-06-10 at 07:26 -0400, Jeff Sheltren wrote:
On Jun 10, 2007, at 7:24 AM, Jeff Sheltren wrote:
> On Jun 10, 2007, at 12:52 AM, Marc Wiriadisastra wrote:
>>
>>
>> Double post but I have removed gcc etc from the list here
>>
http://fedoraproject.org/wiki/Packaging/FullExceptionList
>>
>> <adesklets.spec>
>>
>
> Hi Marc, I took a look at your spec file. Now, keep in mind that I
> don't often (ie. ever) do package reviews, but here's my advise FWIW:
One more thing, I noticed that the adesklet site mentions a patch to
prevent segfaults in the latest version. Is that needed for any
Fedora versions?
-Jeff
--
I appreciate the feedback Jeff. I'm getting errors relating to the
following perl macro's placed in the %file section.
RPM build errors:
File must begin with "/": %{_perl_sitelib}/*
File must begin with "/": %{_perl_vendorlib}/perllocal.pod
File must begin with "/": %{_perl_vendorarch}/auto/adesklets/
File must begin with "/":
%{_perl_vendorarch}/auto/adesklets/.packlist
Also the RPM that I created before with the SPEC file that I emailed to
the list compiled and created the RPM I installed it and ran the
resultant program and I couldn't get it to segfault. Not that I tested
it to thoroughly.
Do you have a link to the explaining of the macro's so I can understand
them better?
The only reason I added python and perl was because the fresh install I
did with the i686 didn't have perl and python in. When I updated it, it
worked but yeah I'll test it.
Again appreciate the feedback I'll have a further play with it but
direction for reading would be appreciated :)
Cheers,
Marc