Hi,
I'm reviewing bijiben: https://bugzilla.redhat.com/show_bug.cgi?id=919265
Pierre-Yves is both the submitter of the package as well as the upstream developer.
The review is in a state where I think the package can be approved, except for the license.
I'm having doubts about the value of the license tag, but that's mostly because it's slightly more complicated than what I've dealt with until now.
I've looked at all the source files, and the result appears to me to be: GPLv3+ and (LGPLv2 or LGPLv3) and LGPLv2+
- The LGPLv2+ files are libgd, which is (by design) bundled into bijiben. - The "LGPLv2 or LGPLv3" files come from Evolution - The GPLv3+ is most of the software, it is the source code for bijiben
Pierre-Yves simplified that to: GPLv3+ and LGPLv3 and LGPLv2+
Which I don't think is a problem.
Could anyone have a look and confirm that the License tag is correct?
I'm sure I'm being overly worried for no reason and it's a very simple case, but as I said, I've never reviewed a package with so many licenses before. :)
Thanks,
On Fri, 2013-03-15 at 16:29 +0800, Mathieu Bridon wrote:
Hi,
I'm reviewing bijiben: https://bugzilla.redhat.com/show_bug.cgi?id=919265
Pierre-Yves is both the submitter of the package as well as the upstream developer.
The review is in a state where I think the package can be approved, except for the license.
I'm having doubts about the value of the license tag, but that's mostly because it's slightly more complicated than what I've dealt with until now.
I've looked at all the source files, and the result appears to me to be: GPLv3+ and (LGPLv2 or LGPLv3) and LGPLv2+
- The LGPLv2+ files are libgd, which is (by design) bundled into bijiben.
- The "LGPLv2 or LGPLv3" files come from Evolution
- The GPLv3+ is most of the software, it is the source code for bijiben
Pierre-Yves simplified that to: GPLv3+ and LGPLv3 and LGPLv2+
Which I don't think is a problem.
Could anyone have a look and confirm that the License tag is correct?
I'm sure I'm being overly worried for no reason and it's a very simple case, but as I said, I've never reviewed a package with so many licenses before. :)
Anyone?
Mathieu Bridon wrote:
On Fri, 2013-03-15 at 16:29 +0800, Mathieu Bridon wrote:
Hi,
I'm reviewing bijiben: https://bugzilla.redhat.com/show_bug.cgi?id=919265
...
Anyone?
the site hosting the .spec/srpm doesn't load for me, so can't comment (yet).
-- rex
On Wed, 2013-03-20 at 12:28 -0500, Rex Dieter wrote:
Mathieu Bridon wrote:
On Fri, 2013-03-15 at 16:29 +0800, Mathieu Bridon wrote:
Hi,
I'm reviewing bijiben: https://bugzilla.redhat.com/show_bug.cgi?id=919265
...
Anyone?
the site hosting the .spec/srpm doesn't load for me, so can't comment (yet).
Tom commented on the review request anyway, so there's no need now.
Thanks anyway for trying to have a look, Rex. :)