On Tue, May 24, 2011 at 09:48:17AM +0300, Akos PASZTORY wrote:
> please check
git://fedorapeople.org/~jolsa/latrace.git
> branch signal_handlers
>
> any comments/testing is welcome ;)
hm, I realized that the code has changed a bit since I last read it, but anyway:
1. in process():
while((wait = waitpid(pa->pid, &status, WNOHANG) == 0) ||
^
isn't here a closing paren missing? ---'
right, I checked the precedence and == is higher than =
2. you could make exit_flag volatile
seems like gcc -O2 I use
does not optimize it out,
but it's probably safer to have it volatile
3. why the SIGSEGV handler?
just saw it in application I was
stealing this from ;)
no special reason really, will need to look around
and think if we can do something smart, like display
bug report info or something.. ideas?
How about those 5 seconds to wait after SIGTERM is
sent to a child.. less/more/configurable?
It has already started to annoy me in the test run ;)
thanks for comments,
I updated the code on top of the signal_handlers branch
jirka
_______________________________________________
latrace mailing list
latrace(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/latrace