On 2020-02-25 10:32, Ken Dreyer wrote:
The cli/koji_cli/commands.py file is massive at this point, and I
don't want to make that problem worse. I (naively) think it would make
more sense to refactor cli/koji_cli/commands.py into a
cli/koji_cli/commands/ directory and to put each sub-command into its
own Python file.
Whenever I've wandered in there, I have wished for this. I've taken the
"commands" package approach in most all my private tools, even for cases
where there's only two sub-commands, and much prefer it if for no other
reason than clean obvious lines of scope and dependency. I can then
neatly put things that they may all share in commands/__init__.py such
as maybe a dynamic dispatcher to enforce that function names are derived
from CLI keywords. (I merely use that as an example, I don't recall if
koji has any such incongruities.) But ... I'm very much a person who
prefers many small files to a few giant ones and this is only my $0.02.