commit 6b775612e8e4ecc1bee53c34ddcd9b0c2fffd840
Author: Michal Srb <msrb(a)redhat.com>
Date: Fri Jun 6 11:45:07 2014 +0200
[dependency] "optional" is None by default
None means that "optional" element was not specified in XML.
python/javapackages/maven/dependency.py | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/python/javapackages/maven/dependency.py
b/python/javapackages/maven/dependency.py
index 5979b6e..86a4793 100644
--- a/python/javapackages/maven/dependency.py
+++ b/python/javapackages/maven/dependency.py
@@ -42,7 +42,7 @@ from lxml.etree import Element, SubElement, tostring
class Dependency(AbstractArtifact):
def __init__(self, groupId, artifactId, extension="",
classifier="",
- version="", scope="", optional=False,
exclusions=set()):
+ version="", scope="", optional=None,
exclusions=set()):
self.groupId = groupId.strip()
self.artifactId = artifactId.strip()
self.extension = extension.strip()
@@ -62,7 +62,7 @@ class Dependency(AbstractArtifact):
item = SubElement(root, "scope")
item.text = self.scope
- if self.optional:
+ if self.optional is not None:
item = SubElement(root, "optional")
item.text = str(self.optional).lower()
@@ -87,7 +87,7 @@ class Dependency(AbstractArtifact):
'classifier': '',
'version': '',
'scope': '',
- 'optional': False}
+ 'optional': None}
parts = POMReader.find_parts(xmlnode, parts)
@@ -96,7 +96,7 @@ class Dependency(AbstractArtifact):
"Empty groupId or artifactId encountered. "
"This is a bug, please report it!")
- if parts['optional'] is not False:
+ if parts['optional'] is not None:
if parts['optional'] == "false":
parts['optional'] = False
elif parts['optional'] == "true":
Show replies by date