https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Bug ID: 1703026 Summary: maven: please drop dependency on chkconfig Product: Fedora Version: 30 Status: NEW Component: maven Assignee: stewardship-sig@lists.fedoraproject.org Reporter: zbyszek@in.waw.pl QA Contact: extras-qa@fedoraproject.org CC: akurtako@redhat.com, jamielinux@fedoraproject.org, java-sig-commits@lists.fedoraproject.org, mhroncok@redhat.com, mizdebsk@redhat.com, msrb@redhat.com, sochotni@redhat.com, stewardship-sig@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Description of problem: Seems to be an unused leftover but it pulls in a few unnecessary packages.
Version-Release number of selected component (if applicable): maven-3.5.4-7.fc30.noarch
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pbrobinson@gmail.com Flags| |needinfo?(mizdebsk@redhat.c | |om)
--- Comment #1 from Miro Hrončok mhroncok@redhat.com --- The dependency was removed:
https://src.fedoraproject.org/rpms/maven/c/b0e012bd7c5bd16b78b3906a1272b1d63...
Added back:
https://src.fedoraproject.org/rpms/maven/c/5317cb37c66350e691266a3abbedd85c8...
Removed again:
https://src.fedoraproject.org/rpms/maven/c/eb4c6cfc75b967a5e5e3bb4b6f0429c47...
The package FTBFS, fix at https://src.fedoraproject.org/rpms/maven/pull-request/2
The last successful build has the dependency. The next successful built won't.
I'd like to know what this little revert war means.
Mikolaj, Petr?
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(pbrobinson@gmail. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- Requires on chkconfig were replaced with requires on /usr/sbin/update-alternatives file by Peter Robinson. At the time of change I was the primary maintainer of maven package. Peter was not co-maintainer of the package. Yet, this change was not consulted with me and I was not informed abut it - I only found out about the change from fedmsg notifications. I reverted the change since it was unjustified and it was made in violation of Fedora policy [1]. Only after that I was contacted by Peter on IRC and asked why I reverted the change. I explained my reasons for preferring explicit dependencies on package names.
The reasons were:
1. I don't welcome changes for the sake of change. There was no technical reason to make the change - at the time chkconfig was the only package providing /usr/sbin/update-alternatives file. Any change poses a risk of regression, therefore changes must be justified.
2. With explicit depenencies spec file is shorter, easier to read and understand. Layers of indirection (rpm macros, file provides) make it harder to understand how the dependency is satisfied. Especially for new contributors.
3. Some tools that I use for automating package maintenance do not support file dependencies. I don't have such dependencies in any of my packages, so I don't have any need to implement support for file dependences. Adding file dependencies to maven package would require me to work on changing the tools I use.
[1] https://fedoraproject.org/wiki/Who_is_allowed_to_modify_which_packages
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mizdebsk@redhat.c |needinfo?(zbyszek@in.waw.pl |om) |) |needinfo?(pbrobinson@gmail. | |com) |
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- Mikolaj, thanks.
Zbyszek, would the current spec file (once built) satisfy what you ask for?
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
--- Comment #4 from Peter Robinson pbrobinson@gmail.com --- (In reply to Mikolaj Izdebski from comment #2)
Requires on chkconfig were replaced with requires on /usr/sbin/update-alternatives file by Peter Robinson. At the time of change I was the primary maintainer of maven package. Peter was not co-maintainer of the package. Yet, this change was not consulted with me and I was not informed abut it - I only found out about the change from fedmsg notifications. I reverted the change since it was unjustified and it was made in violation of Fedora policy [1]. Only after that I was contacted by Peter on IRC and asked why I reverted the change. I explained my reasons for preferring explicit dependencies on package names.
The reasons were:
- I don't welcome changes for the sake of change. There was no technical
reason to make the change - at the time chkconfig was the only package providing /usr/sbin/update-alternatives file. Any change poses a risk of regression, therefore changes must be justified.
- With explicit depenencies spec file is shorter, easier to read and
understand. Layers of indirection (rpm macros, file provides) make it harder to understand how the dependency is satisfied. Especially for new contributors.
- Some tools that I use for automating package maintenance do not support
file dependencies. I don't have such dependencies in any of my packages, so I don't have any need to implement support for file dependences. Adding file dependencies to maven package would require me to work on changing the tools I use.
[1] https://fedoraproject.org/wiki/Who_is_allowed_to_modify_which_packages
The change actually fits just fine with "Minor, general or cleanup changes" outlined in the link referenced.
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
--- Comment #5 from Mikolaj Izdebski mizdebsk@redhat.com --- (In reply to Peter Robinson from comment #4)
The change actually fits just fine with "Minor, general or cleanup changes" outlined in the link referenced.
I disagree.
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|pbrobinson@gmail.com |
--- Comment #6 from Peter Robinson pbrobinson@gmail.com --- (In reply to Mikolaj Izdebski from comment #5)
(In reply to Peter Robinson from comment #4)
The change actually fits just fine with "Minor, general or cleanup changes" outlined in the link referenced.
I disagree.
Sure, you are literally the only one in around 100 packages so ¯_(ツ)_/¯
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zbyszek@in.waw.pl | |) |
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Looks like it. Can we please merge PR#2 and rebuild the package?
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1675352
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1675352 [Bug 1675352] maven: FTBFS in Fedora rawhide/f30
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- maven-3.5.4-10.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9af048c9ac
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- maven-3.5.4-10.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9af048c9ac
https://bugzilla.redhat.com/show_bug.cgi?id=1703026
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |maven-3.5.4-10.fc30 Resolution|--- |ERRATA Last Closed| |2019-05-06 00:45:28
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- maven-3.5.4-10.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1703026 Bug 1703026 depends on bug 1675352, which changed state.
Bug 1675352 Summary: maven: FTBFS in Fedora rawhide/f30 https://bugzilla.redhat.com/show_bug.cgi?id=1675352
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
java-sig-commits@lists.fedoraproject.org