commit b21283baeace37df0f6dd20b21a94957eb67f72e Author: Michal Srb msrb@redhat.com Date: Mon May 12 13:39:10 2014 +0200
[mvn_artifact] It is not safe to modify the sequence being iterated over in the loop, fix it
java-utils/mvn_artifact.py | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) --- diff --git a/java-utils/mvn_artifact.py b/java-utils/mvn_artifact.py index d597156..2383e84 100644 --- a/java-utils/mvn_artifact.py +++ b/java-utils/mvn_artifact.py @@ -164,12 +164,12 @@ def get_dependencies(pom_path): deps.extend([x for x in p.get_dependencies()]) dep_management = get_dependency_management(pom_path)
- for d in deps: - for dm in dep_management: + for d in deps[:]: + for dm in dep_management[:]: if d.artifactId == dm.artifactId and d.groupId == dm.groupId: deps.append(Dependency.merge_dependencies(d, dm)) - deps.pop(deps.index(d)) - dep_management.pop(dep_management.index(dm)) + deps.remove(d) + dep_management.remove(dm)
try: mets = load_metadata()
java-sig-commits@lists.fedoraproject.org