https://bugzilla.redhat.com/show_bug.cgi?id=1317805
Bug ID: 1317805
Summary: %jpackage_script is not compatible with XDG
specification
Product: Fedora
Version: rawhide
Component: jpackage-utils
Assignee: extras-orphan(a)fedoraproject.org
Reporter: jvanek(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: akurtako(a)redhat.com, extras-orphan(a)fedoraproject.org,
java-sig-commits(a)lists.fedoraproject.org,
jerboaa(a)gmail.com, msrb(a)redhat.com,
sochotni(a)redhat.com
the %jpackage_script generates also:
# Source user prefs
if [ -f $HOME/.LauncherName ] ; then
. $HOME/.LauncherName
fi
Which looks really bad. $XDG_* should be followed.
So the correct snippet should be (not tested):
XCFG=$XDG_CONFIG_DIR
if [ "xXCFG" == "x" ] ; then
XCFG=$HOME/.config/.LauncherName
else
XCFG=$XCFG/.LauncherName
fi
if [ -f $XCFG ] ; then
. $XCFG
fi
%jpackage_script is an old macro. It was created before XDG spec
existed. It would be nice to use standardized location for config files,
but I can't just move config file location as it would break user config
files.
Perhaps a second XDG-compliant location could be added next to existing
non-standard config location. Or we could introduce a totally new macro,
which would solve this and many of other issues. New macro would allow
to migrate packages gradually.
--
You are receiving this mail because:
You are on the CC list for the bug.