https://bugzilla.redhat.com/show_bug.cgi?id=1495241
Bug ID: 1495241
Summary: [tomcat] zip -u in spec file causes race condition
Product: Fedora
Version: rawhide
Component: tomcat
Assignee: ivan.afonichev(a)gmail.com
Reporter: tdawson(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: akurtako(a)redhat.com, alee(a)redhat.com,
csutherl(a)redhat.com, ivan.afonichev(a)gmail.com,
java-sig-commits(a)lists.fedoraproject.org,
krzysztof.daniel(a)gmail.com, me(a)coolsvap.net
Description of problem:
zip -u is being used to update META-INF/MANIFEST.MF in jar files
zip -u will "Update existing entries if newer on the file system"
Unfortunately zip is only looking at the minute that a file is updated. We are
finding on fast test machines that the content of the jar, and the new
META-INF/MANIFEST.MF, are being created in the same minute. Thus when the zip
-u is ran, the MANIFEST.MF isn't updated, zip returns a non 0 error code, and
the build fails.
"zip -u" should be changed to "zip", which changes the zip command
from
"update" to "add"
zip (add) will "Update existing entries and add new files. ... This is the
default mode."
If you can change your spec files to use just "zip" instead of "zip
-u", that
will solve this race condition
Version-Release number of selected component (if applicable):
tomcat-8.0.46-1.fc28
How reproducible:
5-95% - depending on the speed of the machine.
Steps to Reproduce:
1. koji build
2.
3.
Actual results:
+ zip -u build/lib/<jar-name>.jar META-INF/MANIFEST.MF
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.oh6WeU (%build)
Bad exit status from /var/tmp/rpm-tmp.oh6WeU (%build)
Child return code was: 1
Expected results:
...
+ zip -u build/lib/<jar-name>.jar META-INF/MANIFEST.MF
updating: META-INF/MANIFEST.MF (deflated 56%)
...
--
You are receiving this mail because:
You are on the CC list for the bug.