https://bugzilla.redhat.com/show_bug.cgi?id=998463
Bug ID: 998463 Summary: javapackages-tools: whitespace breaks XML node matching for pom macros Product: Fedora Version: 18 Component: javapackages-tools Assignee: msimacek@redhat.com Reporter: sochotni@redhat.com QA Contact: extras-qa@fedoraproject.org CC: java-sig-commits@lists.fedoraproject.org, mizdebsk@redhat.com, msrb@redhat.com, sochotni@redhat.com
Description of problem: When artifactId (or other node which is being matched) contains whitespace such as new line it will break XML node matching causing pom modification to fail.
Example snippet: <build> ... <plugins> ... <plugin> <artifactId>maven-compiler-plugin </artifactId> <!-- HERE --> <configuration> <source>1.4</source> <target>1.4</target> </configuration> </plugin ... </plugins> ... </build>
This example was taken from plexus-sec-dispatcher which currently suffers from this problem.
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
--- Comment #1 from Michael Simacek msimacek@redhat.com --- Fixed in upstream commit c3fbde5b.
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED Fixed In Version| |3.0.2-3 Assignee|msimacek@redhat.com |mizdebsk@redhat.com
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- Fixed in javapackages-tools-3.0.2-3
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |VERIFIED
--- Comment #3 from Mikolaj Izdebski mizdebsk@redhat.com --- Verified in rawhide.
$ cat pom.xml <project> <build> <plugins> <plugin> <artifactId>maven-compiler-plugin </artifactId> <!-- HERE --> <configuration> <source>1.4</source> <target>1.4</target> </configuration> </plugin> </plugins> </build> </project>
$ (pom_remove_plugin :maven-compiler-plugin)
$ cat pom.xml <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <build> <plugins> <!-- plugin disabled by maintainer: maven-compiler-plugin --> </plugins> </build> </project>
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|mizdebsk@redhat.com |msimacek@redhat.com QA Contact|extras-qa@fedoraproject.org |mizdebsk@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|3.0.2-3 |3.3.1-1
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|msimacek@redhat.com |mizdebsk@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=998463
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|VERIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-10-02 12:22:39
--- Comment #4 from Mikolaj Izdebski mizdebsk@redhat.com --- I believe that this bug is fixed in javapackages-tools-3.3.1-1, which is available in Fedora Rawhide, so I am closing this bug now.
The build containing the fix can be found at Koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=469008
This bug was fixed in the next release of Fedora, and is not planned to be fixed in the release it was filed against. If you want this bug to be fixed in updates for Fedora 18, please say so in a comment. Otherwise you can update to the newer release of Fedora to get the fix.
java-sig-commits@lists.fedoraproject.org