https://bugzilla.redhat.com/show_bug.cgi?id=1175281
Mattias Ellert <mattias.ellert(a)fysast.uu.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(mattias.ellert@fy |
|sast.uu.se) |
--- Comment #4 from Mattias Ellert <mattias.ellert(a)fysast.uu.se> ---
(In reply to Michael Simacek from comment #1)
%pom_xpath_replace is supposed to be used to replace XML elements.
For replacing text content, there is %pom_xpath_set. Is there any reason why
you cannot use it?
(If you didn't know about it, it might mean that it's not documented well
enough, what documentation did you use?)
I had no idea about %pom_xpath_set. That's why I did not use it.
There is nothing in the documentation of %pom_xpath_replace that suggests that
it is not supposed to be used to replace text nodes. "man pom_xpath_replace"
says:
"pom_xpath_replace - replace XML node from XML file with given code"
A text node is an XML node so the description fits the use case. Reading
further in the man page there is nothing that says that this is not the
preferred macro for replacing text nodes.
I do believe that, even though it is not the preferred way, %pom_xpath_replace
should place the comments in sane locations when used on a text node.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=6JKgWxTH0X&a=cc_unsubscribe