https://bugzilla.redhat.com/show_bug.cgi?id=1171898
Bug ID: 1171898 Summary: maven_depmap.py does not create correct directory ownership for installed poms Product: Fedora Version: rawhide Component: javapackages-tools Severity: medium Assignee: mizdebsk@redhat.com Reporter: orion@cora.nwra.com QA Contact: extras-qa@fedoraproject.org CC: java-sig-commits@lists.fedoraproject.org, mat.booth@redhat.com, mizdebsk@redhat.com, msimacek@redhat.com, msrb@redhat.com
Description of problem:
maven_depmap.py does not record the directory that a pom is installed into, resulting in lots of unowned directories in /usr/share/maven-poms:
file /usr/share/maven-poms/slf4j is not owned by any package file /usr/share/maven-poms/sonatype-oss-parent is not owned by any package file /usr/share/maven-poms/spice-parent is not owned by any package
Version-Release number of selected component (if applicable): javapackages-tools-4.2.0-8.fc22.noarch
https://bugzilla.redhat.com/show_bug.cgi?id=1171898
--- Comment #1 from Orion Poplawski orion@cora.nwra.com --- Generated .mfiles:
%attr(0644,root,root) /usr/share/maven-metadata/sonatype-oss-parent.xml %attr(0644,root,root) /usr/share/maven-poms/sonatype-oss-parent/oss-parent.pom
need a:
%dir /usr/share/maven-poms/sonatype-oss-parent
not sure the %attr() is really necessary. Without it you could just do:
/usr/share/maven-poms/sonatype-oss-parent/
https://bugzilla.redhat.com/show_bug.cgi?id=1171898
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |FutureFeature Priority|unspecified |medium Summary|maven_depmap.py does not |maven_depmap.py: Generate |create correct directory |ownership on mavenpomdir |ownership for installed |subdirectories |poms | Severity|medium |unspecified
Red Hat Bugzilla bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|Bug Fix |Enhancement
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- I will consider this for next javapackages release.
https://bugzilla.redhat.com/show_bug.cgi?id=1171898
Fedora Java SIG java-sig-commits@lists.fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|java-sig-commits@lists.fedo | |raproject.org |
--- Comment #3 from Michal Srb msrb@redhat.com --- I think this may be just a misunderstanding. maven_depmap.py is only used from within %add_maven_depmap macro, i.e. it's only being called on already manually installed artifacts. Since package maintainer had to manually create the subdirectories, I think it's up to him/her to decide which (sub)packages should own them. maven_depmap.py doesn't have enough information to make the decision.
(In reply to Orion Poplawski from comment #0)
file /usr/share/maven-poms/slf4j is not owned by any package file /usr/share/maven-poms/sonatype-oss-parent is not owned by any package file /usr/share/maven-poms/spice-parent is not owned by any package
I looked and it seems that none of these packages call maven_depmap.py. All of them use %mvn_install, which means that xmvn-install is responsible for generating .mfiles in this case. This looks like a bug in XMvn and it should be addressed there, if possible.
java-sig-commits@lists.fedoraproject.org