https://bugzilla.redhat.com/show_bug.cgi?id=1211208
Bug ID: 1211208 Summary: ibus-table-createdb should allow table keys to start with spaces Product: Fedora Version: 22 Component: ibus-table Assignee: mfabian@redhat.com Reporter: mfabian@redhat.com QA Contact: extras-qa@fedoraproject.org CC: dchen@redhat.com, i18n-bugs@lists.fedoraproject.org, kent.neo@gmail.com, me@kaio.net, mfabian@redhat.com, pwu@redhat.com, shawn.p.huang@gmail.com
James Wood> I recently came across the problem of not being able to James Wood> bind to sequences starting with a space. This is caused by James Wood> applying .strip() on line 209 of engine/tabcreatedb.py (in James Wood> phrase_parser). I can't see start stripping being helpful, James Wood> and since it restricts functionality, I think it should be James Wood> replaced by .rstrip() (as well as possibly some other uses James Wood> of .strip() in the same file).
https://bugzilla.redhat.com/show_bug.cgi?id=1211208
--- Comment #1 from Mike FABIAN mfabian@redhat.com --- diff --git a/engine/tabcreatedb.py b/engine/tabcreatedb.py index fd28dcf..880a6d1 100644 --- a/engine/tabcreatedb.py +++ b/engine/tabcreatedb.py @@ -224,7 +224,7 @@ def main (): for l in f: if type(l) != type(u''): l = l.decode('utf-8') - xingma, phrase, freq = l.strip().split('\t')[:3] + xingma, phrase, freq = l.split('\t')[:3] if phrase == 'NOSYMBOL': phrase = u'' list.append ( (xingma, phrase, int(freq), 0) )
https://bugzilla.redhat.com/show_bug.cgi?id=1211208
Mike FABIAN mfabian@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ON_QA
--- Comment #2 from Mike FABIAN mfabian@redhat.com --- Pushed to the testing repository:
https://admin.fedoraproject.org/updates/FEDORA-2015-6137/ibus-table-1.9.5-1.... https://admin.fedoraproject.org/updates/FEDORA-2015-6353/ibus-table-1.9.5-1.... https://admin.fedoraproject.org/updates/FEDORA-2015-6385/ibus-table-1.9.5-1....
https://bugzilla.redhat.com/show_bug.cgi?id=1211208
Mike FABIAN mfabian@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2016-07-06 02:28:38
--- Comment #3 from Mike FABIAN mfabian@redhat.com --- Fixed.
i18n-bugs@lists.fedoraproject.org