Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=488172
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flag| |fedora-review?
--- Comment #2 from Parag AN(पराग) <panemade(a)gmail.com> 2009-04-03 01:43:11 EDT
---
Review:
+ package builds in mock (rawhide i586).
koji build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=1274694
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5981da2341988d13ebd0c6c01bcb047f ibus-table-zhengma-1.1.0.20090402.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlet used.
+ file permissions are appropriate.
+ Not a GUI App.
Suggestions:
1) check header of zhengma.txt table file. Can you confirm license with
upstream if it really is GPLv3+?
2) try adding contents to Changelog file in upstream and add it as %doc
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.