https://bugzilla.redhat.com/show_bug.cgi?id=838871
Bug ID: 838871 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: 17 Priority: unspecified CC: i18n-bugs@lists.fedoraproject.org, jni@redhat.com, petersen@redhat.com, pwu@redhat.com, tagoh@redhat.com Assignee: jni@redhat.com Summary: Apply button is always clickable Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: tagoh@redhat.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: fonts-tweak-tool Product: Fedora
Description of problem: This behavior mislead that the changes may be not applied.
Version-Release number of selected component (if applicable): fonts-tweak-tool-0.0.6-1.fc17.noarch
How reproducible: always
Steps to Reproduce: 1.run fonts-tweak-tool 2. 3.
Actual results: Apply button is clickable regardless of something is changed.
Expected results: it should be reflected according to the current status
Additional info:
https://bugzilla.redhat.com/show_bug.cgi?id=838871
James Ni jni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Fixed In Version| |0.0.7
--- Comment #1 from James Ni jni@redhat.com --- Hi tagoh
I have remove the "Close" button and change "Apply" button to "OK"
The "OK" button will show a pop up window to warn that changes will write to configuration file, when there is changes. The changes include add/remove one language to/from list, or remove all the language.
If there is no changes, press "OK" button just close the window.
https://github.com/jamesni/fonts-tweak-tool/commit/df9aa2255baa4337bcda6267a...
I will include this change in new release 0.0.7.
Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=838871
--- Comment #2 from Fedora Update System updates@fedoraproject.org --- fonts-tweak-tool-0.0.7-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fonts-tweak-tool-0.0.7-1.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=838871
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- fonts-tweak-tool-0.0.7-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fonts-tweak-tool-0.0.7-1.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=838871
--- Comment #4 from Akira TAGOH tagoh@redhat.com --- I can still see this issue on Fonts tab with 0.0.7-1.fc17.
FWIW it looks like the dialog-wise window though, embedding the dialog buttons into the tab looks a bad idea.
https://bugzilla.redhat.com/show_bug.cgi?id=838871
--- Comment #5 from Akira TAGOH tagoh@redhat.com --- I'm wondering if I should open another bug but it may be related to this. so just add a comment here.
Well, due to the thing as I mentioned in the above comment, if one do the following steps, the changes will be missed:
1. Add a language on GTK Language Order tab 2. Switch the tab to Fonts 3. Click the close button
As I told you on IRC, you better consider to use "instant apply".
https://bugzilla.redhat.com/show_bug.cgi?id=838871
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|jni@redhat.com |tagoh@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=838871
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- fonts-tweak-tool-0.0.8-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fonts-tweak-tool-0.0.8-1.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=838871
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- fonts-tweak-tool-0.0.8-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fonts-tweak-tool-0.0.8-1.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=838871
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- Package fonts-tweak-tool-0.0.8-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fonts-tweak-tool-0.0.8-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-11593/fonts-tweak-tool-0... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=838871
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-08-09 19:27:02
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- fonts-tweak-tool-0.0.8-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
i18n-bugs@lists.fedoraproject.org