https://bugzilla.redhat.com/show_bug.cgi?id=2153024
Bug ID: 2153024
Summary: fcitx-fbterm: Calls to undeclared
fcitx_client_enable_ic, fcitx_client_close_ic
functions
Product: Fedora
Version: rawhide
Status: NEW
Component: fcitx-fbterm
Assignee: extras-orphan(a)fedoraproject.org
Reporter: fweimer(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: extras-orphan(a)fedoraproject.org,
i18n-bugs(a)lists.fedoraproject.org,
liangsuilong(a)gmail.com, robinlee.sysu(a)gmail.com,
yanqiyu01(a)gmail.com
Blocks: 2137512 (PortingToModernCHelpNeeded)
Target Milestone: ---
Link ID: Github fcitx/fcitx/pull/521
Classification: Fedora
The build logs and the Fedora C99 show that these functions are called without
a proper previous declaration:
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c: In function
'im_active':
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c:116:5: warning:
implicit declaration of function 'fcitx_client_enable_ic'; did you mean
'fcitx_client_focus_in'? [-Wimplicit-function-declaration]
116 | fcitx_client_enable_ic(client);
| ^~~~~~~~~~~~~~~~~~~~~~
| fcitx_client_focus_in
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c: In function
'im_deactive':
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c:126:5: warning:
implicit declaration of function 'fcitx_client_close_ic'; did you mean
'fcitx_client_reset'? [-Wimplicit-function-declaration]
126 | fcitx_client_close_ic(client);
| ^~~~~~~~~~~~~~~~~~~~~
| fcitx_client_reset
I investigated this and it seems the proper fix is actually in fcitx: Declare
these functions in the appropriate header file. I submitted a pull request to
this effect:
fcitx-gclient: Export fcitx_client_enable_ic, fcitx_client_close_ic
<
https://github.com/fcitx/fcitx/pull/521>
This bug is just a reminder to re-test fcitx-fbterm once fcitx has been updated
accordingly.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2137512
[Bug 2137512] Porting Fedora to modern C: Bugs that need help
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2153024