Hi,
files like /etc/httpd/conf.d/ipa.conf have a VERSION tag. FreeIPA's
updater does not rewrite the file unless the VERSION tag in the template
is higher than the VERSION tag of the existing file. In case the VERSION
tag is equal or higher, the updater does not overwrite the config file.
Is there any particular reason for this behavior? Why does FreeIPA not
simply overwrite the file every time? FreeIPA doesn't support
customization of our config files. For example ipa.conf contains a
warning "This file may be overwritten on upgrades".
We could simplify the installer by removing the version check and always
overwriting FreeIPA own config files.
Pro:
It would reduce code size and maintenance cost while making it simpler
to test the updater. Bug
https://pagure.io/freeipa/issue/7454 didn't
show up earlier, because the code path was never executed in tests. As a
nice side effect, ipa-server-update would be able to 'repair' broken
config files, too.
Con:
It makes it harder to maintain customizations of Apache config file. But
that's not supported any way.
Regards,
Christian
--
Christian Heimes
Senior Software Engineer, Identity Management and Platform Security
Red Hat GmbH,
http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander