[freeipa PR#2136][opened] [Backport][ipa-4-6] Fix pylint 2.0 return-related violations
by tiran
URL: https://github.com/freeipa/freeipa/pull/2136
Author: tiran
Title: #2136: [Backport][ipa-4-6] Fix pylint 2.0 return-related violations
Action: opened
PR body:
"""
Manual backport of PR #2135 to 4.6 branch.
Aiming to support pylint 2.0 some functions and methods must have their
return statements updated in order to fix two new violations:
- `useless-return` (R1711):
Useless return at end of function or method Emitted when a single
"return" or "return None" statement is found at the end of function
or method definition. This statement can safely be removed because
Python will implicitly return None
- `inconsistent-return-statements` (R1710):
Either all return statements in a function should return an
expression, or none of them should. According to PEP8, if any return
statement returns an expression, any return statements where no value
is returned should explicitly state this as return None, and an
explicit return statement should be present at the end of the
function (if reachable)
Issue: https://pagure.io/freeipa/issue/7614
Signed-off-by: Armando Neto <abiagion(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2136/head:pr2136
git checkout pr2136
5 years, 10 months
[freeipa PR#2135][opened] Fix pylint 2.0 return-related violations
by netoarmando
URL: https://github.com/freeipa/freeipa/pull/2135
Author: netoarmando
Title: #2135: Fix pylint 2.0 return-related violations
Action: opened
PR body:
"""
Aiming to support pylint 2.0 some functions and methods must have their
return statements updated in order to fix two new violations:
- `useless-return` (R1711):
Useless return at end of function or method Emitted when a single
"return" or "return None" statement is found at the end of function
or method definition. This statement can safely be removed because
Python will implicitly return None
- `inconsistent-return-statements` (R1710):
Either all return statements in a function should return an
expression, or none of them should. According to PEP8, if any return
statement returns an expression, any return statements where no value
is returned should explicitly state this as return None, and an
explicit return statement should be present at the end of the
function (if reachable)
Issue: https://pagure.io/freeipa/issue/7614
Signed-off-by: Armando Neto <abiagion(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2135/head:pr2135
git checkout pr2135
5 years, 10 months
[freeipa PR#2116][opened] [Backport][ipa-4-5] replica improvements
by tiran
URL: https://github.com/freeipa/freeipa/pull/2116
Author: tiran
Title: #2116: [Backport][ipa-4-5] replica improvements
Action: opened
PR body:
"""
Manual backport of three PRs to 4.5 branch
### Fix CA topology warning, PR #2114
Commit 7284097eedef70dd556270732e6ab8e23501ce09 kept
find_providing_servers('CA') call before enable_services(). Therefore the
list of known CA servers did not contain the current replica.
ipa-replica-install on the first replica with --setup-ca still printed
the CA topology warning.
See: https://pagure.io/freeipa/issue/7566
Signed-off-by: Christian Heimes <cheimes(a)redhat.com>
### replicainstall: DS SSL replica install pick right certmonger host, PR #2115
Extend fix 0f31564b35aac250456233f98730811560eda664 to also move
the DS SSL setup so that the xmlrpc_uri is configured to point
to the remote master we are configuring against.
https://pagure.io/freeipa/issue/7566
Signed-off-by: Rob Crittenden <rcritten(a)redhat.com>
### Tune DS replication settings, PR #2111
Tune 389-DS replication settings to improve performance and avoid
timeouts. During installation of a replica, the value of
nsDS5ReplicaBindDnGroupCheckInterval is reduced to 2 seconds. At the end
of the installation, the value is increased sensible production
settings. This avoids long delays during replication.
See: https://pagure.io/freeipa/issue/7617
Signed-off-by: Christian Heimes <cheimes(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2116/head:pr2116
git checkout pr2116
5 years, 10 months