[freeipa PR#1664][opened] ipa-server-install: handle error when calling kdb5_util create
by flo-renaud
URL: https://github.com/freeipa/freeipa/pull/1664
Author: flo-renaud
Title: #1664: ipa-server-install: handle error when calling kdb5_util create
Action: opened
PR body:
"""
ipa-server-install creates the kerberos container by calling
kdb5_util create -s -r $REALM -x ipa-setup-override-restrictions
but does not react on failure of this command. The installer fails later
when trying to create a ldap principal, and it is difficult to diagnose the
root cause.
The fix raises a RuntimeException when kdb5_util fails, to make sure
that the installer exits immediately with a proper error message.
Note: no test added because there is no easy reproducer. One would need to
stop dirsrv just before calling kdb5_util to simulate a failure.
https://pagure.io/freeipa/issue/7438
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1664/head:pr1664
git checkout pr1664
6 years, 1 month
Contribute/Code wiki page update
by Florence Blanc-Renaud
Hi all,
I recently updated the Contribute/Code wiki page
(https://www.freeipa.org/page/Contribute/Code), especially the sections
related to Code Review Process.
As developers, we often prefer to deliver code rather than review other
people's code, but I really think that the code reviews are an essential
part of our job. They allow to ensure that code quality is preserved,
but also foster discussions and help share experience.
So as always, comments or suggestions are welcome!
Flo
6 years, 1 month