----- Original Message -----
> From: "David Lehman" <dlehman(a)redhat.com>
> To: anaconda-patches(a)lists.fedorahosted.org
> Sent: Tuesday, November 11, 2014 4:32:51 PM
> Subject: [PATCH 4/6] The minimum size for a btrfs member device has increased to 16
MiB.
>
> ---
> tests/devicelibs_test/btrfs_test.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/devicelibs_test/btrfs_test.py
> b/tests/devicelibs_test/btrfs_test.py
> index 7799543..b6cdd05 100755
> --- a/tests/devicelibs_test/btrfs_test.py
> +++ b/tests/devicelibs_test/btrfs_test.py
> @@ -165,7 +165,7 @@ class BTRFSAsRootTestCase2(BTRFSMountDevice):
> class BTRFSAsRootTestCase3(loopbackedtestcase.LoopBackedTestCase):
>
> def __init__(self, methodName='runTest'):
> - super(BTRFSAsRootTestCase3, self).__init__(methodName=methodName,
> deviceSpec=[Size("8 MiB")])
> + super(BTRFSAsRootTestCase3, self).__init__(methodName=methodName,
> deviceSpec=[Size("16 MiB")])
>
> def testSmallDevice(self):
> """ Creation of a smallish device will result in an error if
the
> --
> 1.9.3
>
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
>
We discussed the attached patch, directed at the same problem, a while ago.
I like the fact that that patch adds a MIN_MEMBER_SIZE constant to devicelibs.btrfs.
This records a value that may be used by not-test code in future.
I think that btrfs's MIN_MEMBER_SIZE is unlikely to go down, so this value
will be correct until it has to go up again.
We said that _preCreate() didn't really add anything, but doesn't hurt either.
And the additional tests are kind of nice for alerting us to changes in the min member
size,
should they happen.
Sure, it looks good. I don't see why it wasn't pushed back then.
- mulhern
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches