----- Original Message -----
From: "Vratislav Podzimek" <vpodzime(a)redhat.com>
To: "anaconda patch review" <anaconda-patches(a)lists.fedorahosted.org>
Sent: Thursday, June 26, 2014 2:05:46 AM
Subject: Re: [libblockdev 00/10] Some libblockdev fiddles
Thanks for the patch set in the first place!
On Wed, 2014-06-25 at 17:35 -0400, mulhern wrote:
> The first four are things I stumbled across while trying to build w/out
> warnings.
Apart from the comments about things I've already fixed these look good
to me.
>
> The last five are all about the Makefile. There's plenty more to do, but
> I'ld
> like feedback before I go any further.
The Makefile is more like a stub just allowing running tests. All the
patches look good to me, but for further development it might be better
to switch to autotools. I'm no expert in plain makefiles nor in
autotools so I leave it up to you which way you want to go.
You should now be all set to push the patches to the libblockdev GitHub
repository.
--
Vratislav Podzimek
Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
Ok. I pushed the non-Makefile ones, but I'll work on the Makefile
ones a bit more. I'ld rather get a more or less automatic Makefile,
at least the actual build parts, up and running before I tackle
autotools.
- mulhern