----- Original Message -----
From: "mulhern" <amulhern(a)redhat.com>
To: anaconda-patches(a)lists.fedorahosted.org
Cc: "mulhern" <amulhern(a)redhat.com>
Sent: Wednesday, June 25, 2014 5:35:29 PM
Subject: [libblockdev 00/10] Some libblockdev fiddles
The first four are things I stumbled across while trying to build w/out
warnings.
The last five are all about the Makefile. There's plenty more to do, but I'ld
like feedback before I go any further.
That is, I know that the Makefile is now in a state where some parts are more
automatic, but others are not as automatic as they could be.
However, I wanted to put these patches up for review anyway, because converting the
Makefile to really fully automatic will take a good deal more work, and if this
is the wrong direction I'ld like to find that out sooner.
mulhern (10):
Do not start using next_line until needed.
Do not check for NULL value for ret
Discard const modifier on ret
Put const modifier on some things very heavily
Add an initial .gitignore file.
Use pattern rules to generate plugin boilerplate.
Remove unnecessary header file from LIBRARY_FILES
Start a clean target.
Make build-library into a file target.
Leave out link-time flags when compiling.
.gitignore | 6 ++++++
Makefile | 50
+++++++++++++++++++++++++-------------------
src/lib/plugin_apis/common.h | 2 +-
src/plugins/crypto.c | 6 ++----
src/plugins/lvm.c | 4 ++--
src/plugins/swap.c | 7 +++----
src/plugins/test_lvm.c | 2 +-
src/utils/sizes.c | 2 +-
8 files changed, 44 insertions(+), 35 deletions(-)
create mode 100644 .gitignore
--
1.9.3