On 29/06/12 14:06 +0530, Samridh wrote:
This patch adds hwp creation, deletion and listing functionality to
the cli.
To test the functionality, please modify the :url entry in your ~/.aeolus-cli file to
something like ":url: http://<host>/conductor" i.e, remove the /api from
the :url entry. This is because all the conductor side funcitonality has been implemented
by modifying the hardware_profile cotroller itself. You could also modify the routes.rb on
the conductor side, but I personally found the former easier to do.
I'll try to reply in more detail later, but this is not going to be
able to go in as is. I'll list a few of the large problems here, and
get into details later or tomorrow once I finish some other things on
my todo list:
* You can't break the entrypoint in the configu file like this, it
will cause the existing stuff that _does_ require /api in the uri to
break
* hwp is _not_ a bolton to aeolus-image, it belongs in a separate
command (this could be just hwp or something else, not sure
offhand). Calling aeolus-image --hwp makes no sense, as an hwp is
not an image.
* where are the tests? we cannot accept new functionality without
tests.
Thanks for the effort on this, I am sure with a little discussion we
can get things in a state more ready to commit.
-j