On Tue, Apr 10, 2012 at 05:04:24PM +0200, Jirka Tomasek wrote:
>
>Nice work!
>
>A few notes:
>1) The section#usermenu looks a bit wrong when the user name is
>long and it is forced to be multiple lines. This also affects the
>hover dropdown which displays the first item shifted to the left
>(the shift also occurs when name fits into one line)
>
>2) The header.scss replaces the Masthead, so whole Masthead part in
>layout.scss (marked with comment App Masthead -- v.0.0.2
>[masthead]) should be removed and necessary changes should be part
>of header.scss (section#usermenu code). header#masthead and
>ul#user-menu are not used any more so it should be removed.
>
>3) Notifications dropdown looks a bit odd and should be reworked to
>respond the design
>
>These changes can be done as part of UI Racionalisation #3067 so
>I'll leave it up to you if you make the changes or not.
>
>ACK to the patchset
>
>
>Jirka
Also header styling seems to be still work in progress so the details
don't matter right now
http://file.bne.redhat.com/~afitzsim/shots/after.png
<
http://file.bne.redhat.com/%7Eafitzsim/shots/after.png>
It is indeed a work in progress, though I took what Andy sent out as
a longer-term brainstorming, so I think we should look at getting the
other work buttoned up now.
Thanks for the review!
-- Matt