On Wed, May 09, 2012 at 03:44:29PM -0400, Tzu-Mainn Chen wrote:
This patchset updates events/instances/deployments to be
soft_deleted. The gem of choice is 'paranoia'; I chose this because it was the
one gem I could find that:
a) worked for Rails 3
b) handled associations properly
c) handled callbacks correctly
Mainn
Unfortunately, I can't get the gem via the Fedora mirrors at the moment.
I assume it hasn't made it live just yet. I installed from koji for
testing purposes though, but I don't think we should push until this
becomes available.
As we discussed on IRC, I haven't finished this patch review, and won't
get to do so tonight. Someone else can pick it up tomorrow; if not, I'll
review it tomorrow. Two quick nits -- we might want to explore adding an
index on the deleted_at columns, since they're now a part of the default
scope; also, I get some whitespace warnings when applying patch 4 with
the tests (it cites lines 61, 65, 77, and 79).
Apologies for the incomplete review, but it doesn't make sense to push
before the gem is publicly available anyway.
-- Matt