On 20/05/2011, at 1:10 AM, Jason Guiditta wrote:
On Thu, 2011-05-19 at 09:47 -0400, Mike Orazi wrote:
> On 05/18/2011 11:47 PM, Mo Morsi wrote:
<snip>
>
>>
>>> diff --git a/bin/aeolus-cleanup b/bin/aeolus-cleanup
>>> index 87fb405..d064b32 100644
>>> --- a/bin/aeolus-cleanup
>>> +++ b/bin/aeolus-cleanup
>>> @@ -2,8 +2,9 @@
>>>
>>> export FACTER_AEOLUS_ENABLE_HTTPS=true
>>> export FACTER_AEOLUS_ENABLE_SECURITY=false
>>> -puppet /usr/share/aeolus-configure/aeolus_uninstall.pp \
>>> +puppet
/usr/share/aeolus-configure/modules/aeolus_recipe/manifests/defaults.pp \
>>> --modulepath=/usr/share/aeolus-configure/modules/ \
>>> - --logdest=/var/log/aeolus-configure/aeolus-cleanup.log \
>>> + --external_nodes '/usr/sbin/aeolus-node cleanup'
--node_terminus exec \
>>
>> Do we need this /usr/sbin/aeolus-node script? Can we just use the node
>> yaml directly w/ a --node_terminus set to 'yaml'?
>>
>
> We might be able to away without the script but I'm not sure. I'd
> rather leave it as is for now and take it out in a future patch if it is
> possible to remove it.
>
I don't know puppet, so this may be invalid/impossible (seems unlikely),
but generally, I don't like having to use explicit paths in _any_ ruby
code, as it makes it non-platform agnostic. Usually there is a way to
generically point to some executable or config in ruby, and I would
think puppet would have something similar. I know we are not totally
cross-platform anyway, but I would advocate keeping those limitations as
minimal as possible. That said, this could certainly be addressed
later, just my two cents on direction overall.
Similar thoughts here, but for the log file location. Generally it's the
kind of thing people set in a config file. ie:
/etc/sysconfig/aeolus-configure
# location of the logfile
#CONFIGURE_LOGFILE=/var/log/aeolus-configure/aeolus-configure.log
But, not exactly urgent to implement. :)
Regards and best wishes,
Justin Clift
--
Aeolus Community Manager
http://www.aeolusproject.org