On 07/13/11 - 01:01:53PM, mtaylor(a)redhat.com wrote:
From: Martyn Taylor <mtaylor(a)redhat.com>
---
.../image_factory/aeolus-image/examples/tdl.rng | 206 ++++++++++++++++++++
.../image_factory/aeolus-image/lib/base_command.rb | 6 +
.../aeolus-image/lib/build_command.rb | 10 +
.../aeolus-image/spec/base_command_spec.rb | 14 ++
.../aeolus-image/spec/build_command_spec.rb | 11 +
.../spec/fixtures/invalid_template.tdl | 18 ++
.../aeolus-image/spec/fixtures/valid_template.tdl | 18 ++
7 files changed, 283 insertions(+), 0 deletions(-)
create mode 100644 services/image_factory/aeolus-image/examples/tdl.rng
I'm of two minds about this.
On the one hand, it is nice to give the user feedback right away if their TDL
is invalid. On the other hand, oz/imagefactory already does this checking.
The duplication means that if we add a new feature to the TDL (which we do
rather frequently), we have to update both oz/imagefactory and this RNG to
allow it through. It makes us less nimble.
I think I would prefer a way to get error messages from the imagefactory
printed out on the aeolus-image command-line. Has anyone taken a look at
doing it this way instead?
--
Chris Lalancette