On Fri, 2011-08-05 at 11:54 -0700, Richard Su wrote:
Allow all providerimages to be shown if value passed to
--providerimages is "all".
Simplifies finding the image id given a template name in RHEV or vm name in vSphere.
---
lib/list_command.rb | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
Mostly ACK, few minor comments:
1. Please add an example to the help, --proivderimages is listed in
options, but not examples (ideally this should be updated in man page at
same time, since it seems to not be generated from the same source)
2. This is not your fault, but I think our tests are getting a bit thin
here. I looked to see if there was a test for any of the flags to the
list command, and there are not, which dismays me.
3. Specs fail (again, dont think this is related to your patch), so
reminder that everyone should be running specs before ACKing a patch.
If you could make the minor doc fixes, once you push this, I'll fix the
tests. Thanks,
-j