On 08/04/2011 11:39 AM, Chris Lalancette wrote:
On 08/03/11 - 02:45:22PM, Richard Su wrote:
> Added package_provider parameter to default_configure to control whether missing
packages should be installed automatically. Set value to yum to auto install (the default
moving forward) or to rpm to disable auto install.
>
> Fixed a few dependency issues that cropped up since we can't rely on certain
conditions being statisfied if aeolus-all is not installed before running aeolus-configure
for the first time.
Arg. I thought we killed this, but it keeps rearing its ugly head.
I still don't see why we want this. Those who are installing via packages will
have all the packages they need. Those who don't are developers and know what
they are doing.
All this patch will do is to ensure that our package dependencies are broken,
and stay broken, for a long time. I'd much rather fail fast, find out our
dependencies are broken, and then fix it for everyone.
NACK from me.
Heh, I think this was a misunderstanding of the issue in redmine.
Like you said, we had talked about it before and the decision was made
to rely on a yum install of the components before configure was run.
The actual issue in redmine read "As an end-user, I can chose to allow
or disallow aeolus-configure from installing missing packages" which
would entail defaulting to the current behavior but allowing the end
user to configure the package source.
So an end user could use aeolus-configure to install packages via
apt-get on Ubuntu for example or via a central puppetmaster server.
So I agree, NACK to this patch.
To round out feature #1962, the end user should be able to configure the
package source via the node yaml (defaulting to the current 'rpm'
package source where it just to fails w/ an error if a required package
isn't present).
-Mo