On 02/16/2011 09:37 AM, Mike Orazi wrote:
> ---
> .../deltacloud_recipe/manifests/image-factory.pp | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/recipes/deltacloud_recipe/manifests/image-factory.pp
b/recipes/deltacloud_recipe/manifests/image-factory.pp
> index 6d4be23..c937f66 100644
> --- a/recipes/deltacloud_recipe/manifests/image-factory.pp
> +++ b/recipes/deltacloud_recipe/manifests/image-factory.pp
> @@ -4,14 +4,9 @@ class deltacloud::image-factory inherits deltacloud {
> # TODO: Fix me, find a better way to do this...
> # We need to also install this rpm from amazon
> if $enable_packages {
> - package{"ec2-ami-tools":
> - provider => "rpm",
> - source =>
"http://s3.amazonaws.com/ec2-downloads/ec2-ami-tools.noarch.rpm",
> - ensure => 'installed' }
> -
> package { 'rubygem-deltacloud-image-builder-agent':
> provider => 'yum', ensure =>
'installed',
> - require => [Package['ec2-ami-tools'],
Yumrepo['deltacloud_arch', 'deltacloud_noarch']]}
> + require => [Yumrepo['deltacloud_arch',
'deltacloud_noarch']]}
> }
>
>
Looks good, save a couple small nits.
* the issue clalance brought up about removing the ec2-ami-tools bit
from the uninstall section
* could you remove the 'TODO' above the section you are removing
* I tried this on F13 and while after configure ran, ec2-ami-tools
was not present, nor was euca2ools. I'm not sure if this is the desired
functionality.
If this F13 issue is moot and once you remove the TODO and ec2-ami-tools
bits in the uninstall section, ACK.
-Mo
_______________________________________________
aeolus-devel mailing list
aeolus-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/aeolus-devel
I'll pull the TODO out as well and resend the ammended patch.
Thanks,
Mike