On 09/09/2011 01:11 AM, Mo Morsi wrote:
Overall looks good, though there are a few things that need to be
fixed
before this can go in.
On 09/08/2011 03:31 PM, Richard Su wrote:
> index b76cee5..8df15ac 100644
> --- a/recipes/aeolus/manifests/profiles/default.pp
> +++ b/recipes/aeolus/manifests/profiles/default.pp
> @@ -11,33 +11,34 @@ class aeolus::profiles::default {
> aeolus::conductor::login{"admin": password =>
"password",
> require => Aeolus::Conductor::Site_admin['admin']}
>
> - aeolus::provider{"mock":
> - type => 'mock',
> - port => 3002,
> + aeolus::conductor::provider{"mock":
> + type_id => '1',
> + url => 'http://localhost:3002/api',
> require => Aeolus::Conductor::Login["admin"] }
> +
"type_id" is the major caveat with this patch. We should be referring to
provider type in the same way we were, eg by name, not by id.
So the real problem here is that -configure is really just hacking web
forms in the absence of a real REST API here. The form that is being
filled in has a picklist for provider_type -- and the _value_ is the ID,
not the name. For a UI form, this is the right way to do it. So this
will have to do until we put an API call here for provider creation --
this would, of course, allow passing in a provider type via the
deltacloud_driver name (which is also unique)
> aeolus::conductor::hwp{"hwp1":
> memory => "512",
> cpu => "1",
> - storage => "1",
> + storage => "",
> architecture => "x86_64",
> require => Aeolus::Conductor::Login["admin"] }
This change breaks rackspace support for this HWP, is it necessary?
If this breaks rackspace support, we've got a matching bug. nil in a
front-end HWP means "match everything, I don't care" -- so if this
_does_ fail for rackspace, we should fix the matching bug, not change
the HWP, since the nil storage is the only way to match for VMware.
Would it be more desirable to default to the 'mock' driver instead of
'ec2'?
The rest looks good and the patch works. As soon as these changes are
made, I'll ACK.
-Mo
_______________________________________________
aeolus-devel mailing list
aeolus-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/aeolus-devel This patch works for me
too.
Scott