Hi all,
This mammoth patchset implements task 3030, or at least Phase 1[1] thereof. We switch to
a common header and footer with Katello (though styled a little differently.) The wiki
page linked below contains a screenshot of how it should look as well, plus an explanation
of why we're doing this. (The short version: so that our application looks similar to
Katello.)
Please note that patches 4 and 5 are from Brian McLaughlin, and represent his first
patches sent to the list[2]. So if this is ACKed, he should be given commit privileges per
[3]. To give credit where due, most of the initial design came from Andy Fitzsimon based
on mocks from the Red Hat UX team. I worked on weaving it into our existing layout, and
Brian picked up the ongoing UI work.
Also note that this was a tough patch to send, and maybe a tough patch to apply. The
reason is that there's an uberlong line, which exceeds the 998-character line limit
that MIME allows, and git freaks out. The line gets chopped up in sending the email out,
which breaks the patch unless you manually rejoin it. (And mutt unhelpfully
"marks" this by adding an exclamation point on the end of the line, which
isn't intuitive. You need to remove that.) The uberlong line is a base64 image, so its
length is legitimate -- jsut annoying when trying to email it. It should be fairly easy to
tweak before applying the patch, but let me know if it's a giant disaster and I can
just push this to a branch somewhere for review that way. (Ultimately, the offending line
is removed by Brian's patch, but I had added it earlier, so it shows up twice. Since
it spans patches by different authors, I didn't want to try to obliterate references
to it.)
-- Matt
[1]
https://www.aeolusproject.org/redmine/projects/aeolus/wiki/Shared_UI_with...
[2] I'm sending them only because we had been working on a branch because this was a
fairly long-running task, and because I wanted to reorder history on the branch.
[3]
https://www.aeolusproject.org/redmine/projects/aeolus/wiki/Git_Commit_Acc...
Nice work!
A few notes:
1) The section#usermenu looks a bit wrong when the user name is long and
it is forced to be multiple lines. This also affects the hover dropdown
which displays the first item shifted to the left (the shift also occurs
when name fits into one line)
2) The header.scss replaces the Masthead, so whole Masthead part in
layout.scss (marked with comment App Masthead -- v.0.0.2 [masthead])
should be removed and necessary changes should be part of header.scss
(section#usermenu code). header#masthead and ul#user-menu are not used
any more so it should be removed.
3) Notifications dropdown looks a bit odd and should be reworked to
respond the design
These changes can be done as part of UI Racionalisation #3067 so I'll
leave it up to you if you make the changes or not.
ACK to the patchset
Jirka