On 09/09/2011 01:12 AM, Mo Morsi wrote:
On 08/26/2011 01:58 PM, Scott Seago wrote:
> + def encoded_url_with_driver_and_provider
> + url_extras = ";driver=#{provider_type.deltacloud_driver}"
> + if deltacloud_provider
> + url_extras += ";provider=#{CGI::escape(deltacloud_provider)}"
> + end
> + return url + url_extras
> + end
>
One additional comment w/ this patch. If deltacloud_provider is
specified, the resulting url will be:
;driver=#{provider_type.deltacloud_driver};provider=#{CGI::escape(deltacloud_provider)}
whereas what I believe we want is
;driver=#{provider_type.deltacloud_driver}&provider=#{CGI::escape(deltacloud_provider)}
Note the 2nd ';' is now an '&' to conform to http guidelines.
According to the deltacloud docs, the ; is used in both places. In this
case, since this is actually getting inserted _before_ the
method-specific part of the URL (due to restriction on what we can do w/
condor), I think the & would throw off URL parsing for subsequent bits
in any case.
That said, the above will go away once condor is removed, so I'm
inclined to keep it now (it works), and it will be removed entirely once
condor is fully removed.
Scott
-Mo
_______________________________________________
aeolus-devel mailing list
aeolus-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/aeolus-devel