On 08/04/11 - 06:22:38AM, Mark McLoughlin wrote:
On Wed, 2011-08-03 at 15:44 -0500, Steve Loranz wrote:
> I am always torn on this. I know it's in PEP008 and I want to be a
> good little Python developer, but the fact is that displays have
> advanced quite a bit since the original run of Seinfeld and if we use
> descriptive method and variable names, we'll be splitting every damn
> line and still be going over 80 char in many instances.
>
> I'd like somebody others to chime in here and give an opinion.
>
> -steve
Random €0.02
80 chars is a good guideline, but there's no need to be ultra strict
about it. Sticking to the guideline can be good or bad for legibility on
wider displays, depending on the context.
Looking at the patch, I prefer the original version in most cases.
e.g. some of the lines in BuildDispatcher.py approach 120 chars, which I
agree is far too long. I see that as a symptom of too many parameters to
methods and too long method names, though. Splitting the code across
multiple lines doesn't improve the situation IMHO, it needs more serious
refactoring to reduce the length of the lines.
Yes, I was going to look at this a bit more, to see if I could do some
refactoring.
I'd just shut pylint up on this one Chris :-)
While I still think it helps, opinion is against me so I'll drop the patch.
--
Chris Lalancette