Change in vdsm[master]: net: report expected devices in OVS netinfo
phoracek at redhat.com
phoracek at redhat.com
Wed May 11 15:22:23 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: report expected devices in OVS netinfo
......................................................................
Patch Set 12: Verified+1
(4 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/57067/11/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
PS11, Line 102:
: interfaces set on it.
> OVS implicitly defines a port as bond when it has two or more interfaces se
True:
[root at centos7-vdsmbox tests]# ovs-vsctl add-bond br0 bond1 dummy_2 dummy_3
[root at centos7-vdsmbox tests]# ovs-appctl bond/show bond1
---- bond1 ----
bond_mode: active-backup
bond may use recirculation: no, Recirc-ID : -1
bond-hash-basis: 0
updelay: 0 ms
downdelay: 0 ms
lacp_status: off
active slave mac: 00:00:00:00:00:00(none)
slave dummy_2: disabled
may_enable: false
slave dummy_3: disabled
may_enable: false
[root at centos7-vdsmbox tests]# ovs-vsctl --id=@d3 get Interface dummy_3 -- remove Port bond1 interfaces @d3
[root at centos7-vdsmbox tests]# ovs-appctl bond/show bond1
no such bond
ovs-appctl: ovs-vswitchd: server returned an error
PS11, Line 171: urn {vlan_name: vla
> vlanid
Done
PS11, Line 179:
> Uninitialized variables... better have tests covering the scenario where we
Done
https://gerrit.ovirt.org/#/c/57067/11/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:
Line 271: 'netmask': '',
Line 272: 'vlanid': TEST_VLAN
Line 273: }
Line 274: }
Line 275: }
> We should try and avoid testing private funcs/methods.
Done
Line 276:
Line 277: @MonkeyPatch(info, 'getMtu', lambda *args: 1500)
Line 278: @MonkeyPatch(info, 'is_ipv6_local_auto', lambda *args: True)
Line 279: @MonkeyPatch(info, 'get_gateway',
--
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list