Change in vdsm[master]: net: report expected devices in OVS netinfo

edwardh at redhat.com edwardh at redhat.com
Wed May 11 14:36:04 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: report expected devices in OVS netinfo
......................................................................


Patch Set 11: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/57067/11/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

PS11, Line 102: It is
              :         our responsibility to check whether a port is bond or not.
OVS implicitly defines a port as bond when it has two or more interfaces set on it.

(Is the sentence true?)


PS11, Line 171: net_attrs['vlanid']
vlanid


PS11, Line 179: return {vlan_name: vlan_info}
Uninitialized variables... better have tests covering the scenario where we do not enter the if body.


https://gerrit.ovirt.org/#/c/57067/11/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

Line 271:                                           else '::'))
Line 272:     @MonkeyPatch(info, 'getIpInfo',
Line 273:                  lambda *args: (TEST_ADDRESS, TEST_NETMASK,
Line 274:                                 [TEST_ADDRESS_WITH_PREFIX], []))
Line 275:     def test_ovs_netinfo(self):
We should try and avoid testing private funcs/methods.

Can we avoid it here?
Line 276:         obtained_netinfo = info._get_netinfo(MockedOvsInfo())
Line 277:         self.assertEqual(obtained_netinfo, self.TEST_NETINFO)
Line 278: 
Line 279:     def test_fake_expected_devices(self):


-- 
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list