Change in vdsm[master]: hostdev: add support for hotplug

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 30 12:32:05 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: hostdev: add support for hotplug
......................................................................


Patch Set 16:

(1 comment)

https://gerrit.ovirt.org/#/c/42661/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2081:                 dev_object.detach()
Line 2082:             except libvirt.libvirtError:
Line 2083:                 # We couldn't detach one of the devices. Halt.
Line 2084:                 self.log.exception('Could not detach a device from a host.')
Line 2085:                 return response.error('hostdevDetachFail')
> let's consider this scenario.
Detaching a detached device is noop. Previous patches in this series actually even embraced that - we avoid reattaching the devices and keep them detached.
Line 2086: 
Line 2087:         assigned_devices = []
Line 2088: 
Line 2089:         # Hard part is done, we have detached all devices without errors.


-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list