Change in vdsm[master]: hostdev: add support for hotplug

fromani at redhat.com fromani at redhat.com
Wed Mar 30 12:26:38 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for hotplug
......................................................................


Patch Set 16: Code-Review-1

(1 comment)

looks ok, -1 because one question inside

https://gerrit.ovirt.org/#/c/42661/16/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2081:                 dev_object.detach()
Line 2082:             except libvirt.libvirtError:
Line 2083:                 # We couldn't detach one of the devices. Halt.
Line 2084:                 self.log.exception('Could not detach a device from a host.')
Line 2085:                 return response.error('hostdevDetachFail')
let's consider this scenario.
Engine sends 3 devices (actually any number >= 2).
First detach succeeds, second fails; method exits with error. So far so good.
After a little while Engine retries sending the very same data. What would happen now?

I expect it to work, but could be wishful thinking from mine :)
Most likely you already explained in the past, but would you please remind me if it is safe to detach twice a device?
Line 2086: 
Line 2087:         assigned_devices = []
Line 2088: 
Line 2089:         # Hard part is done, we have detached all devices without errors.


-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list